Removing getSchemaContext#357
Merged
aruniverse merged 6 commits intonextfrom May 12, 2025
Merged
Conversation
pankhur94
changed the title
aruniverse
reviewed
May 5, 2025
aruniverse
reviewed
May 5, 2025
aruniverse
reviewed
May 5, 2025
…c.tsx Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
ben-polinsky
approved these changes
May 5, 2025
hl662
approved these changes
May 5, 2025
Contributor
hl662
left a comment
hl662
left a comment
There was a problem hiding this comment.
I assume the deprecation errors will be tackled in a separate PR?
aruniverse
approved these changes
May 12, 2025
aruniverse
changed the title
getSchemaContext
grigasp
reviewed
May 13, 2025
| enablePerformanceMonitors={true} | ||
| selectionStorage={unifiedSelectionStorage} | ||
| getSchemaContext={getSchemaContext} | ||
| getSchemaContext={(iModel) => iModel.schemaContext} |
Member
There was a problem hiding this comment.
I believe this prop was removed from Viewer in this PR?
Contributor
Author
There was a problem hiding this comment.
yes. that is right
| ]} | ||
| selectionStorage={unifiedSelectionStorage} | ||
| getSchemaContext={getSchemaContext} | ||
| getSchemaContext={(iModel) => iModel.schemaContext} |
Member
There was a problem hiding this comment.
I believe this prop was removed from Viewer in this PR?
Contributor
Author
There was a problem hiding this comment.
yes that is right.
Member
|
Sorry I commented after merging the PR - noticed it just now :( |
Member
|
We needed to also register the ECSchemaRpcInterface by default with this PR, I forgot. I have added it in this commit, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iTwin/itwinjs-core#7977 added
schemaContexttoiModelConnection, no longer require it as a prop in the viewer